Skip to content

test: validate GVEC QA Boozer chartmaps#334

Open
krystophny wants to merge 3 commits intomainfrom
feature/boozer-chartmap-gvec-qa
Open

test: validate GVEC QA Boozer chartmaps#334
krystophny wants to merge 3 commits intomainfrom
feature/boozer-chartmap-gvec-qa

Conversation

@krystophny
Copy link
Copy Markdown
Member

Summary

Add the GVEC QA comparison path on top of the real-Cartesian Boozer chartmap contract.

This slice adds:

  • GVEC-to-Boozer-chartmap conversion for the shared QA case
  • strict roundtrip comparison against the external GVEC chartmap
  • common-case end-to-end QA benchmarking and artifacts
  • CI dependency alignment for GVEC-backed slow tests

Verification

cmake --build build -j$(nproc)
ctest --test-dir build --output-on-failure -R '^(test_boozer_chartmap_roundtrip|test_boozer_chartmap_gvec_qa|test_e2e_boozer_chartmap)$'

100% tests passed, 0 tests failed out of 3

Base automatically changed from feature/boozer-chartmap-realcart to main March 28, 2026 17:38
## Summary

Add the full GVEC and real-Cartesian Boozer chartmap layer on top of the
VMEC validation stack.

This PR now absorbs the old top PR 327. The real-Cartesian contract
belongs here, because this is the first layer where the generalized
non-cylindrical Boozer toroidal parameter actually matters end to end.

This layer adds:

- GVEC state -> Boozer chartmap NetCDF conversion
- real-Cartesian `x,y,z` export for the Boozer grid instead of the
earlier pseudo-Cartesian embedding
- `zeta_convention='boozer'` fixtures and refreshed QA/figure-8
chartmaps on that contract
- QA common-case VMEC/GVEC comparison on the shared chartmap path
- figure-8 QUASR/GVEC golden validation and reviewer plots
- benchmark/artifact helpers used by the end-to-end GVEC coverage
- CI installation of `gvec` for the slow GVEC-backed Python tests

## Stack

- base: `feature/boozer-chartmap-qa`
- head: `feature/boozer-chartmap-gvec`

## Validation scope in this PR

- shared QA case across:
  1. direct VMEC Boozer
  2. VMEC-exported Boozer chartmap
  3. GVEC-exported Boozer chartmap
- figure-8 QUASR -> GVEC -> Boozer chartmap -> SIMPLE golden validation

## Review

Primary GVEC/QUASR review: @Rykath
SIMPLE-maintainer follow-up: @krystophny
@krystophny krystophny force-pushed the feature/boozer-chartmap-gvec-qa branch from 3a42c9b to fbd730d Compare March 28, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant