Open
Conversation
## Summary Add the full GVEC and real-Cartesian Boozer chartmap layer on top of the VMEC validation stack. This PR now absorbs the old top PR 327. The real-Cartesian contract belongs here, because this is the first layer where the generalized non-cylindrical Boozer toroidal parameter actually matters end to end. This layer adds: - GVEC state -> Boozer chartmap NetCDF conversion - real-Cartesian `x,y,z` export for the Boozer grid instead of the earlier pseudo-Cartesian embedding - `zeta_convention='boozer'` fixtures and refreshed QA/figure-8 chartmaps on that contract - QA common-case VMEC/GVEC comparison on the shared chartmap path - figure-8 QUASR/GVEC golden validation and reviewer plots - benchmark/artifact helpers used by the end-to-end GVEC coverage - CI installation of `gvec` for the slow GVEC-backed Python tests ## Stack - base: `feature/boozer-chartmap-qa` - head: `feature/boozer-chartmap-gvec` ## Validation scope in this PR - shared QA case across: 1. direct VMEC Boozer 2. VMEC-exported Boozer chartmap 3. GVEC-exported Boozer chartmap - figure-8 QUASR -> GVEC -> Boozer chartmap -> SIMPLE golden validation ## Review Primary GVEC/QUASR review: @Rykath SIMPLE-maintainer follow-up: @krystophny
3a42c9b to
fbd730d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the GVEC QA comparison path on top of the real-Cartesian Boozer chartmap contract.
This slice adds:
Verification